Add TransformFunctionProvider to DynamicConfigTransformer#6881
Merged
Conversation
Signed-off-by: Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
✅ License Header Check PassedAll newly added files have proper license headers. Great work! 🎉 |
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
May 26, 2026
|
|
||
| private Class<?> resolveClassForMethod(final List<String> functionProviders, String methodName, Class<?> parameterType) throws ReflectiveOperationException { | ||
| if (functionProviders.size() == 1) { | ||
| return Class.forName(functionProviders.get(0)); |
Member
There was a problem hiding this comment.
We should use this instead:
Class.forName(className, false, this.getClass().getClassLoader());
It will not run any static initializers. This let's us check that this is supposed to be a function.
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
May 27, 2026
| // Inner test helper classes for invokeMethod validation tests | ||
| private static final String PROVIDER_PKG = "org.opensearch.dataprepper.pipeline.parser.transformer.dataprepper_transformer."; | ||
|
|
||
| // --- invokeMethod: Happy path --- |
Member
There was a problem hiding this comment.
Let's drop these dangling comments.
dlvenable
requested changes
May 27, 2026
| protected String getSourceCoordinationIdentifier() { | ||
| return System.getenv(SOURCE_COORDINATION_IDENTIFIER_ENVIRONMENT_VARIABLE); | ||
| } | ||
| public Object invokeMethod(final List<String> functionProviders, String methodName, Class<?> parameterType, Object arg) throws ReflectiveOperationException { |
Member
There was a problem hiding this comment.
This should be private or package-private.
dlvenable
reviewed
May 27, 2026
dlvenable
reviewed
May 27, 2026
| DynamicConfigTransformer transformer = new DynamicConfigTransformer(ruleEvaluator); | ||
| assertThat(transformer.getAccountIdFromRole(testRoleArn)).isEqualTo(testAccountId); | ||
| List<String> providers = Collections.singletonList( | ||
| "org.opensearch.dataprepper.pipeline.parser.transformer.DynamicConfigTransformerTest$ValidProviderNoAnnotation"); |
Member
There was a problem hiding this comment.
This is going to fail simply by being in the wrong package name. You need this to be in a package with dataprepper_transformers.
dlvenable
reviewed
May 27, 2026
dlvenable
reviewed
May 27, 2026
| assertThat(transformer.getAccountIdFromRole(testRoleArn)).isNull(); | ||
| List<String> providers = Collections.singletonList( | ||
| "org.opensearch.dataprepper.pipeline.parser.transformer.DynamicConfigTransformerTest$ValidProviderNoAnnotation"); | ||
| assertThrows(Exception.class, () -> |
Member
There was a problem hiding this comment.
It would be good to look at the message of the exception and verify it contains at least a little bit of the expected string. This would have shown that this wasn't testing what you expected.
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
May 28, 2026
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
approved these changes
May 28, 2026
sb2k16
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a type-safe mechanism for dynamically invoking transformation functions during
pipeline template resolution. Previously, utility methods (e.g., calculateDepth, getAccountIdFromRole)
lived directly in DynamicConfigTransformer and were invoked reflectively on this. This was fragile,
untestable in isolation, and violated separation of concerns.
Changes
New API contracts (data-prepper-api):
• PipelineTransformFunctionProvider — marker interface that classes must implement to be valid function providers
• @TransformationFunction — method-level annotation marking methods as callable from template YAML FUNCTION_NAME placeholders
Externalized functions (data-prepper-plugins/aws-plugin):
• Created PipelineTransformFunctions with all 5 static utility methods (calculateDepth, calculateDepthForRdsSource, getSourceCoordinationIdentifierEnvVariable, getIncludePrefixForRdsSource, getAccountIdFromRole)
• Each method is public static, annotated with @TransformationFunction, and the class implements PipelineTransformFunctionProvider
Rule model changes (data-prepper-pipeline-parser):
• Added function_providers field to RuleTransformerModel (deserialized from rule YAML)
• Threaded functionProviders through RuleFileEvaluation → RuleEvaluatorResult → DynamicConfigTransformer
• invokeMethod() now validates:
Rule YAML updates:
• Added function_providers to all production rule files (rds-rule.yaml, rds-joins-rule.yaml, mongodb-rule.yaml, documentdb-rule.yaml)
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.